Repository navigation
fix: Search selections of partly loaded groups and Select all exclusions - #103617
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 similar comment
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@MelvinBot review |
Code reviewI found no blocking bugs. The selection, exclusion and checkbox logic holds up. There is one gap to fix and one edge case to check. 1. Fix: "Download receipts" still shows when a partly loaded group is checked. The merged selection swaps the group's rows for its To match the "only whole-group actions" rule, gate this option on 2. Check: deleting an expense from a header-checked, partly loaded group.
What I checked and found correct
This review is from reading the code at |
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
…election-exclusions # Conflicts: # src/components/Search/SearchBulkActionsButton.tsx # tests/unit/Search/SearchSelectionFooterTest.tsx
…ep row actions next to a cash back row
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai. |
|
All yours @situchan |
…election-exclusions # Conflicts: # src/components/Search/SearchList/ListItem/ExpenseReportListItem.tsx # src/components/Search/SearchWriteActionsProvider.tsx # src/components/Search/selectionBuilders.ts
…so the new expense stays unchecked
…election-exclusions
Great Job. Addressed. As well as Melvin comments |
|
@MelvinBot review |
|
Conflicts! |
|
🤖 Web test steps verification results: Code tracing still shows the previously reported indeterminate-header edge case. Browser verification stopped during grouped-view setup; none of the ten scenarios ran.
view run · no recording available |
|
🤖 Web test steps verification results: No new regression confirmed at
view run · no recording available |
…election-exclusions # Conflicts: # src/components/Search/SearchSelectionFooter.tsx # tests/unit/Search/useSearchSnapshotTest.ts # tests/unit/hooks/useSearchBulkActionsTest.ts
|
All yours @stitesExpensify |
|
Friendly Bump @stitesExpensify Thanks |
stitesExpensify
left a comment
There was a problem hiding this comment.
Pretty complex change, but it looks good AFAICT (and the bots). I think we're good to go
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.5.34-0 🚀
|
|
No FullStory changes needed — this PR fixes existing Search selection, counts, totals, and bulk-action behavior without adding new controls, screens, or sensitive-content surfaces. |
|
No help site update needed — this PR fixes existing selection and bulk-action behavior without adding a new workflow or making any existing article sentence incorrect. |
|
Deploy Blocker #106334 was identified to be related to this PR. |
|
Deploy Blocker #106377 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |


Explanation of Change
This is part 4 of #90539 (shift+click range selection). While building ranges in Search, I found that when a group hadn't loaded all of its expenses, its checkbox, the selected count and total, and the bulk actions disagreed about what was selected. This PR makes them agree.
In grouped searches (by category, tag and so on), a group loads its expenses a page at a time. With this change:
With Select all on:
Fixed Issues
$ #90539
PROPOSAL:
Tests
Prerequisites: use a workspace with its default categories and add these expenses:
Test 1. Checking a group that hasn't fully loaded selects all of it
Test 2. A group shows partly checked when only some of it is selected
Test 3. Expenses that load later come in checked
Test 4. Expenses checked lower down stay checked after you open an expense
Test 5. Checking every expense of a group one by one shows a full check
Test 6. A new expense added to a fully checked group stays unchecked
Test 7. Deleting an expense keeps its group checked
Test 8. Unchecking a group after one of its expenses moves out clears it
Test 9. A fully loaded group selects the expenses it shows after one leaves it, open or collapsed
type:expense status:drafts group-by:from. If you have more than 50 draft expenses, add a filter that only these three match, such as a category they share, so your group loads in full.Test 10. A new expense added to a checked group that's still loading stays unchecked
type:expense group-by:from. Your own group needs more than 50 expenses.Offline tests
Same as tests, except that a group's "Show more" link is hidden while offline, so test 3 and the "Show more" steps of tests 1 and 4 need a connection.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
1with3.mp4
2.mp4
4.mp4
5.mp4
6.mp4
7.mp4
8.mp4